Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fabricitem)!: enable multi-format support #171

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(fabricitem)!: enable multi-format support #171

wants to merge 5 commits into from
+1,125 −207

Conversation

DariuszPorowski
Copy link
Member

@DariuszPorowski DariuszPorowski commented Dec 23, 2024 •
edited
Loading

📥 Pull Request

❓ What are you trying to address

This pull request introduces multi-format support for Fabric Items and makes the format attribute mandatory. The changes include updates to documentation and the addition of new format options for various resources.

✨ Description of new changes

Key Changes:

Supported Notebook formats:

  • Accepted values are jpynb and py

Supported Report formats:

  • Accepted values are PBIR and PBIR-Legacy

Supported Semantic Model formats:

  • Accepted values are TMDL and TMSL

Supported Spark Job Definition formats:

  • Accepted value is SparkJobDefinitionV1

Items without specific format takes Default

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Changelog Preview

v0.1.0-dev - January 24, 2025

💥 Breaking

  • #171 The format attribute is now REQUIRED for Resources/Data-Sources with definition support.
    Currently applicable to the following Resources/Data-Sources: Report, Notebook, Semantic Model, and Spark Job Definition.

  • #185 Using preview resources or data sources now needs explicit opt-in at the provider level configuration by setting the preview attribute to true.
    This is to ensure that users are aware of the risks of using preview resources or data sources in production environments.
    Usage of any preview feature will result in a warning message in the Terraform output.

✨ Added

  • #168 Added support for multi-format Notebook Resource/Data-Source.
    By using format attribute, you can now define the format of the Notebook Resource/Data-Source. Accepted values are jpynb, and py.

  • #171 Added support for multi-format Report Resource/Data-Source.
    By using format attribute, you can now define the format of the Report Resource/Data-Source. Accepted values are PBIR, and PBIR-Legacy.

  • #171 Added support for multi-format Semantic Model Resource/Data-Source.
    By using format attribute, you can now define the format of the Semantic Model Resource/Data-Source. Accepted values are TMSL, and TMDL.

  • #135 Definition support in the fabric_eventhouse Resource

  • #156 Definition support in the fabric_eventhouse Data-Sources

  • #201 Added additional properties for fabric_spark_workspace_settings Data-Source and Resource:

  • high_concurrency.notebook_pipeline_run_enabled (Boolean)
  • job.conservative_job_admission_enabled (Boolen)
  • job.session_timeout_in_minutes (Number)

💫 Changed

  • #194 Enabled SPN support for Warehouse

🪲 Fixed

  • #174 Provider produced inconsistent result after apply error appears when using fabric_domain_workspace_assignments multiple times due to enforce assignments based only on TF configuration and ignoring the real state on the Fabric side.
    Resource must only manage TF provided configuration and ignore any configuration provided outside TF.

  • #190 Fixed typo in the "Creating an App Registration for the User context" doc

@DariuszPorowski DariuszPorowski added this to the 2025-01 milestone Dec 23, 2024
@DariuszPorowski DariuszPorowski force-pushed the feat/fabitem-multiformat branch from ea6ecc7 to 684ccbc Compare December 23, 2024 17:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 72% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 63% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0 ➖
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 ✔
Summary 73% (4016 / 5506) 0 ✔

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.14851% with 45 lines in your changes missing coverage. Please review.

Project coverage is 76.72%. Comparing base (857d238) to head (a0c4a4f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...work/validators/patterns_if_attribute_is_one_of.go 74.10% 29 Missing ⚠️
.../pkg/fabricitem/models_resource_item_definition.go 57.14% 6 Missing ⚠️
...item/resource_item_config_definition_properties.go 0.00% 3 Missing ⚠️
internal/pkg/fabricitem/definition.go 96.96% 2 Missing ⚠️
internal/pkg/fabricitem/resource_schema.go 88.88% 2 Missing ⚠️
internal/provider/utils/values.go 66.66% 2 Missing ⚠️
internal/pkg/fabricitem/models_resource_item.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   76.60%   76.72%   +0.11%     
==========================================
  Files         149      151       +2     
  Lines       12997    13175     +178     
==========================================
+ Hits         9957    10109     +152     
- Misses       3035     3062      +27     
+ Partials        5        4       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski force-pushed the feat/fabitem-multiformat branch from 684ccbc to a9e96cf Compare December 23, 2024 20:00
@DariuszPorowski DariuszPorowski force-pushed the feat/fabitem-multiformat branch from 9425538 to a0c4a4f Compare January 24, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloZaiden PabloZaiden PabloZaiden approved these changes

Assignees

@DariuszPorowski DariuszPorowski

Labels
None yet
Projects
None yet
Milestone
2025-01
Development

Successfully merging this pull request may close these issues.

[FEAT] fabric_notebook support for .py file as definition source
3 participants
@DariuszPorowski @codecov-commenter @PabloZaiden